Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency ranges supported by elie29/zend-phpdi-config in the installer configuration #99

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix dependency ranges supported by elie29/zend-phpdi-config in the installer configuration #99

merged 1 commit into from
Dec 20, 2022

Conversation

elie29
Copy link
Contributor

@elie29 elie29 commented Nov 20, 2022 •
edited by Ocramius
Loading

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Take into account all supported PHP versions with elie29/zend-phpdi-config

Fixes #71

@elie29
The configuration for the installer is wrong mezzio#71
d88de53 
Signed-off-by: Elie NEHME <elie29@users.noreply.github.com>
@elie29
Copy link
Contributor Author

elie29 commented Nov 20, 2022

@froschdesign this is on the required branch

@elie29 elie29 mentioned this pull request Nov 20, 2022
Closed
@Ocramius Ocramius added Bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 21, 2022
@Ocramius Ocramius modified the milestones: 3.12.0, 3.11.1 Nov 21, 2022
Ocramius
Ocramius approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't know how to verify this.

@elie29
Copy link
Contributor Author

elie29 commented Nov 21, 2022

LGTM, although I don't know how to verify this.

We addressed the installation issue but not the configuration part. See #94
Thx @Ocramius

@elie29
Copy link
Contributor Author

elie29 commented Nov 29, 2022

@froschdesign is everything good? or I need to make some modifications? thx

@elie29 elie29 requested review from Ocramius and removed request for froschdesign December 20, 2022 09:06
@froschdesign
Copy link
Member

The package versions in composer.json should be compared with the installer: I have created an issue report for this.

@Ocramius Ocramius assigned Ocramius and unassigned froschdesign Dec 20, 2022
@Ocramius
Copy link
Member

Bringing this home, thanks @elie29 and @froschdesign!

@Ocramius Ocramius merged commit e5294d6 into mezzio:3.11.x Dec 20, 2022
@Ocramius Ocramius changed the title The configuration for the installer is wrong #71 Fix dependency ranges supported by elie29/zend-phpdi-config in the installer configuration Dec 20, 2022
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
@elie29 elie29 deleted the patch-2 branch December 21, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign approved these changes

@Ocramius Ocramius Awaiting requested review from Ocramius

Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.
3 participants
@elie29 @froschdesign @Ocramius